-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: ensure ToastManager
is layered above PortalManager
to enable adding toast notifications within a portal
#936
Conversation
…e adding toast notifications within a portal
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #936 +/- ##
=======================================
Coverage 77.80% 77.80%
=======================================
Files 403 403
Lines 6632 6632
=======================================
Hits 5160 5160
Misses 1472 1472 ☔ View full report in Codecov by Sentry. |
Tonic UI DemoOn 2024-10-07 03:28:52 +0000, PR #936 (55c37bc) was successfully deployed. You can view it at the following link: |
PR Type
enhancement, documentation
Description
ToastManager
to be abovePortalManager
in the main application component and usage examples to ensure proper layering for toast notifications.PortalManager
andToastManager
to provide clearer setup instructions and simplified code examples.Changes walkthrough 📝
_app.page.js
Reorder ToastManager above PortalManager in App component
packages/react-docs/pages/_app.page.js
ToastManager
to be abovePortalManager
.index.page.mdx
Reorder ToastManager above PortalManager in usage example
packages/react-docs/pages/getting-started/usage/index.page.mdx
ToastManager
to be abovePortalManager
in example.index.page.mdx
Update PortalManager setup documentation
packages/react-docs/pages/components/portal-manager/index.page.mdx
PortalManager
.index.page.mdx
Update ToastManager setup documentation
packages/react-docs/pages/components/toast-manager/index.page.mdx
ToastManager
.